Update sbt-mdoc to 2.5.0 #14
Conversation
![banno-diy-steward[bot]](https://avatars.githubusercontent.com/u/371161?s=60&v=4){kind=small}
|
build is failing because sbt-mdoc dropped support for java 8, but we still cross-compile for java 8. I'm looking into how we can limit site generation to just java 11 but without dropping 8 from our cross versions |
| @@ -21,8 +21,8 @@ val scalafixV = "0.11.1" | |||
| ThisBuild / crossScalaVersions := Seq(Scala213, "2.12.18") | |||
| ThisBuild / scalaVersion := Scala213 // the default Scala | |||
| ThisBuild / githubWorkflowJavaVersions := Seq( | |||
| JavaSpec.temurin("8"), | |||
| JavaSpec.temurin("11") | |||
| JavaSpec.temurin("11"), // the first java is the default java, don't change the order | |||
There was a problem hiding this comment.
If I'm reading this correctly, it will publish with Java 11. I think that's fine for internal projects (and would like to know any where it's not, because this keeps coming up, and it's long past time). But if we proceed with that, I don't see a point to testing on Java 8.
There was a problem hiding this comment.
I don't think this is true, because tlJdkRelease is still java 8, and that's what sets the target jvm version for the compiled code (I didn't know this yesterday, I've just been asking Arman about it 😅)
There was a problem hiding this comment.
Okay, that should work. I knew about that setting, but its default value comes as a surprise. I suggest we set that one explicitly.
I'm going to start identifying projects on 8 and chasing them upward, because there are too many variants of this conversation right now for no known (to me) users.
There was a problem hiding this comment.
Okay, just pushed that change!
About this PR
📦 Updates org.scalameta:sbt-mdoc from
2.4.0to2.5.0📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: